Re: [PATCH] require_work_tree broken with NONGIT_OK

From: Gabriel Filion <lelutin@gmail.com>
Date: Feb 15, 2010, 07:24 UTC
Message-ID: <4B78F6CB.2070304@gmail.com>
In-Reply-To: <7vzl3bj95l.fsf@alter.siamese.dyndns.org>

On 2010-02-15 01:38, Junio C Hamano wrote:

Show 20 quoted lines

> Gabriel Filion <lelutin@gmail.com> writes:
> 
>> diff --git a/git-sh-setup.sh b/git-sh-setup.sh
>> index d56426d..8de2f03 100755
>> --- a/git-sh-setup.sh
>> +++ b/git-sh-setup.sh
>> @@ -128,7 +128,7 @@ cd_to_toplevel () {
>>  }
>>   require_work_tree () {
>> -	test $(git rev-parse --is-inside-work-tree) = true ||
> 
> This needs to have dq around it, as "Not a git repository" case we fatal
> out without any output, like this:
> 
> 	test "$(git rev-parse --is-inside-work-tree 2>/dev/null)" = true ||
> 
>> +	test git rev-parse --is-inside-work-tree >/dev/null 2>&1 ||
> 
> I don't think this would ever work with "test" at the beginning.
>

Well, it would seem you are right! my bad for thinking that "test" was actually evaluating any command given in the expression :\

Your implementation seems to be working better and fixes the problem. Thanks for reviewing the patch.

-- 
Gabriel Filion