git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] require_work_tree broken with NONGIT_OK

From
Jeff King <peff@peff.net>
Date
Feb 15, 2010, 05:34 UTC
Message-ID
<20100215053404.GK3336@coredump.intra.peff.net>
In-Reply-To
<4B78C4D3.90407@gmail.com>
On Sun, Feb 14, 2010 at 10:51:47PM -0500, Gabriel Filion wrote:
Show 7 quoted lines
> When sourcing git-sh-setup after having set NONGIT_OK, calling the
> function require_work_tree while outside of a git repository shows a
> syntax error.
> 
> This is caused by the call to "git rev-parse --is-inside-work-tree"
> printing a sentence when it is called outside of a git repository.
> Relying on the return code is better.

I think your fix is fine, but your analysis is slightly wrong. If we are not in a work tree, the sentence goes to stderr, and nothing goes to stdout (which is what makes "test" unhappy).

This is not just a nitpick of your commit message, but I was worried given some other recent discussion that we were accidentally sending that message to stdout, which would be a bug. But we're not.

-Peff
Previous: Gabriel FilionNext: Junio C Hamano
Message 2 of 6 in “require_work_tree broken with NONGIT_OK”
  1. require_work_tree broken with NONGIT_OKGabriel Filion, Feb 15, 2010
  2. Jeff KingFeb 15, 2010
  3. Junio C HamanoFeb 15, 2010
  4. Gabriel FilionFeb 15, 2010
  5. Jeff KingFeb 15, 2010
  6. Gabriel FilionFeb 15, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.