git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5 v2] Worktree/Gitdir at root directory

From
João Carlos Mendes Luís <jonny@jonny.eng.br>
Date
Feb 12, 2010, 13:05 UTC
Message-ID
<4B755229.6000502@jonny.eng.br>
In-Reply-To
<4B752BA1.9080105@kdbg.org>
Johannes Sixt wrote:
Show 20 quoted lines
> Nguyễn Thái Ngọc Duy schrieb:
>> So here we go again. Changes are:
>>
>>  - Support DOS drives as root path (Thanks Hannes)
>>  - Fix one "broken" test that I was too lazy to do last time
>>  - t1509-root-worktree.sh will refuse to run under root permission
>>
>> I did not test it on Windows, so an Ack from someone who actually 
>> tests it on Windows
>> is really appreciated.
>
> I don't see any regressions in may tests on Windows, but I actually 
> don't know what to test (the chroot test doesn't work on Windows). I 
> did test on the root of a partition
>
>    T:\> git init
>    T:\> cd foo
>    T:\foo> git add bar
>
> and it works as expected.
Beware: My first proposed patch "worked" at this level, but failed 
completely when I wanted to commit.   Try more operations just to be sure.

The auto test routines include a ram-disk creation, for windows case, but I'm not sure how portable this would be.

Previous: Johannes SixtNext: Johannes Sixt
Message 9 of 10 in “Worktree/Gitdir at root directory”
  1. 0/5 Worktree/Gitdir at root directoryNguyễn Thái Ngọc Duy, Feb 11, 2010
  2. 1/5 make_absolute_path(): Do not append redundant slashNguyễn Thái Ngọc Duy, Feb 11, 2010
  3. 2/5 init-db, rev-parse --git-dir: do not append redundant slashNguyễn Thái Ngọc Duy, Feb 11, 2010
  4. 3/5 Add is_root_path()Nguyễn Thái Ngọc Duy, Feb 11, 2010
  5. Johannes SixtFeb 12, 2010
  6. 4/5 Support working directory located at rootNguyễn Thái Ngọc Duy, Feb 11, 2010
  7. 5/5 Add test for using Git at root directoryNguyễn Thái Ngọc Duy, Feb 11, 2010
  8. Johannes SixtFeb 12, 2010
  9. João Carlos Mendes LuísFeb 12, 2010
  10. Johannes SixtFeb 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.