git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] make_absolute_path(): Do not append redundant slash

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Feb 11, 2010, 14:43 UTC
Message-ID
<1265899403-15904-2-git-send-email-pclouds@gmail.com>
In-Reply-To
<1265899403-15904-1-git-send-email-pclouds@gmail.com>

When concatenating two paths, if the first one already have '/', do not put another '/' in between the two paths.

Usually this is not the case as getcwd() won't return '/foo/bar/', except when you are standing at root, then it will return '/'.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 abspath.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/abspath.c b/abspath.c
index b88122c..c91a29c 100644
--- a/abspath.c
+++ b/abspath.c
@@ -54,8 +54,9 @@ const char *make_absolute_path(const char *path)
 			if (len + strlen(last_elem) + 2 > PATH_MAX)
 				die ("Too long path name: '%s/%s'",
 						buf, last_elem);
-			buf[len] = '/';
-			strcpy(buf + len + 1, last_elem);
+			if (len && buf[len-1] != '/')
+				buf[len++] = '/';
+			strcpy(buf + len, last_elem);
 			free(last_elem);
 			last_elem = NULL;
 		}
-- 
1.7.0.rc2.182.g3adef
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 2 of 10 in “Worktree/Gitdir at root directory”
  1. 0/5 Worktree/Gitdir at root directoryNguyễn Thái Ngọc Duy, Feb 11, 2010
  2. 1/5 make_absolute_path(): Do not append redundant slashNguyễn Thái Ngọc Duy, Feb 11, 2010
  3. 2/5 init-db, rev-parse --git-dir: do not append redundant slashNguyễn Thái Ngọc Duy, Feb 11, 2010
  4. 3/5 Add is_root_path()Nguyễn Thái Ngọc Duy, Feb 11, 2010
  5. Johannes SixtFeb 12, 2010
  6. 4/5 Support working directory located at rootNguyễn Thái Ngọc Duy, Feb 11, 2010
  7. 5/5 Add test for using Git at root directoryNguyễn Thái Ngọc Duy, Feb 11, 2010
  8. Johannes SixtFeb 12, 2010
  9. João Carlos Mendes LuísFeb 12, 2010
  10. Johannes SixtFeb 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.