[PATCH] git gui: Quote git path properly when starting another gui in a submodule
- From
Jens Lehmann <jens.lehmann@web.de>
- Date
- Jan 28, 2010, 21:20 UTC
- Message-ID
- <4B61FFA7.4090205@web.de>
- In-Reply-To
- <20100128025647.GB8166@spearce.org>
In do_git_gui() the path of the git executable has to be put into a list, otherwise calling it will fail when when spaces are present in its path.
Reported-by: Heiko Voigt <hvoigt@hvoigt.net> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de> ---
Am 28.01.2010 03:56, schrieb Shawn O. Pearce:
> Jens Lehmann (2): > git-gui: Use git diff --submodule when available > git-gui: Add a special diff popup menu for submodules
Today Heiko reported me this bug I introduced with the second patch. Sorry for the hassle.
git-gui/git-gui.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh index a64191d..840f45c 100755 --- a/git-gui/git-gui.sh +++ b/git-gui/git-gui.sh @@ -2000,7 +2000,7 @@ proc do_git_gui {} { # -- Always start git gui through whatever we were loaded with. This # lets us bypass using shell process on Windows systems. # - set exe [_which git] + set exe [list [_which git]] if {$exe eq {}} { error_popup [mc "Couldn't find git gui in PATH"] } else {
-- 1.7.0.rc0.163.g808df.dirty