Re: [PATCH] git gui: Quote git path properly when starting another gui in a submodule

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jan 28, 2010, 23:45 UTC
Message-ID: <20100128234516.GB20488@spearce.org>
In-Reply-To: <4B61FFA7.4090205@web.de>

Jens Lehmann <Jens.Lehmann@web.de> wrote:

Show 15 quoted lines

> In do_git_gui() the path of the git executable has to be put into a list,
> otherwise calling it will fail when when spaces are present in its path.
> 
> Reported-by: Heiko Voigt <hvoigt@hvoigt.net>
> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
> ---
> 
> 
> Am 28.01.2010 03:56, schrieb Shawn O. Pearce:
> > Jens Lehmann (2):
> >       git-gui: Use git diff --submodule when available
> >       git-gui: Add a special diff popup menu for submodules
> 
> Today Heiko reported me this bug I introduced with the second patch.
> Sorry for the hassle.

Applied, thanks.

-- 
Shawn.