git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/4] engine.pl: Fix a recent breakage of the buildsystem generator

From
Sebastian Schuberth <sschuberth@gmail.com>
Date
Jan 22, 2010, 23:48 UTC
Message-ID
<4B5A3958.5060505@gmail.com>
In-Reply-To
<4B5A03EF.1030208@ramsay1.demon.co.uk>
On 22.01.2010 21:00, Ramsay Jones wrote:
Show 16 quoted lines
> Commit ade2ca0c (Do not try to remove directories when removing
> old links, 27-10-2009) added an expression to a 'test' using an
> '-o' or connective. This resulted in the buildsystem generator
> mistaking a conditional 'rm' for a linker command. In order to
> fix the breakage, we filter out all 'test' commands before then
> attempting to identify the commands of interest.
>
> Signed-off-by: Ramsay Jones<ramsay@ramsay1.demon.co.uk>
> ---
>
> Changes from v1, in response to comments from Pete Harlan and
> Sebastian Schuberth:
>
>      - remove second (useless) regex from condition in filter code
>      - remove the commented out version of the original filter code
>      - re-worded commit message to reflect the above changes
Acked-by: Sebastian Schuberth <sschuberth@gmail.com>
Thanks again!
-- 
Sebastian Schuberth
Previous: Ramsay Jones
Message 2 of 2 in “engine.pl: Fix a recent breakage of the buildsystem generator”
  1. 1/4 engine.pl: Fix a recent breakage of the buildsystem generatorRamsay Jones, Jan 22, 2010
  2. Sebastian SchuberthJan 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.