From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Fri, 22 Jan 2010 23:48:40 GMT
Subject: Re: [PATCH v2 1/4] engine.pl: Fix a recent breakage of the buildsystem generator
Message-ID: <4B5A3958.5060505@gmail.com>
In-Reply-To: <4B5A03EF.1030208@ramsay1.demon.co.uk>

On 22.01.2010 21:00, Ramsay Jones wrote:

> Commit ade2ca0c (Do not try to remove directories when removing
> old links, 27-10-2009) added an expression to a 'test' using an
> '-o' or connective. This resulted in the buildsystem generator
> mistaking a conditional 'rm' for a linker command. In order to
> fix the breakage, we filter out all 'test' commands before then
> attempting to identify the commands of interest.
>
> Signed-off-by: Ramsay Jones<ramsay@ramsay1.demon.co.uk>
> ---
>
> Changes from v1, in response to comments from Pete Harlan and
> Sebastian Schuberth:
>
>      - remove second (useless) regex from condition in filter code
>      - remove the commented out version of the original filter code
>      - re-worded commit message to reflect the above changes

Acked-by: Sebastian Schuberth <sschuberth@gmail.com>

Thanks again!

-- 
Sebastian Schuberth