git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 04/18] date.c: mark file-local function static

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Jan 12, 2010, 08:37 UTC
Message-ID
<4B4C34B3.3010508@viscovery.net>
In-Reply-To
<1263282781-25596-5-git-send-email-gitster@pobox.com>
Junio C Hamano schrieb:
Show 25 quoted lines
> diff --git a/date.c b/date.c
> index 5d05ef6..45f3684 100644
> --- a/date.c
> +++ b/date.c
> @@ -9,7 +9,7 @@
>  /*
>   * This is like mktime, but without normalization of tm_wday and tm_yday.
>   */
> -time_t tm_to_time_t(const struct tm *tm)
> +static time_t tm_to_time_t(const struct tm *tm)
>  {
>  	static const int mdays[] = {
>  	    0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334
> diff --git a/git-compat-util.h b/git-compat-util.h
> index 5c59687..85dea12 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -198,7 +198,6 @@ extern void warning(const char *err, ...) __attribute__((format (printf, 1, 2)))
>  extern void set_die_routine(NORETURN_PTR void (*routine)(const char *err, va_list params));
>  
>  extern int prefixcmp(const char *str, const char *prefix);
> -extern time_t tm_to_time_t(const struct tm *tm);
>  
>  static inline const char *skip_prefix(const char *str, const char *prefix)
>  {

This one is used from compat/mingw.c for the gettimeofday emulation. Please leave it extern.

-- Hannes
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 24 in “mark file-local symbols static”
  1. 00/18 mark file-local symbols staticJunio C Hamano, Jan 12, 2010
  2. 01/18 bisect.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  3. 02/18 builtin-rev-list.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  4. 03/18 pretty.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  5. 04/18 date.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  6. Johannes SixtJan 12, 2010
  7. Junio C HamanoJan 12, 2010
  8. Johannes SixtJan 12, 2010
  9. 05/18 http.c: mark file-local functions staticJunio C Hamano, Jan 12, 2010
  10. 06/18 entry.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  11. 07/18 parse-options.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  12. 08/18 read-cache.c: mark file-local functions staticJunio C Hamano, Jan 12, 2010
  13. 09/18 remote-curl.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  14. 10/18 quote.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  15. 11/18 submodule.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  16. 12/18 utf8.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  17. 13/18 mailmap.c: remove unused functionJunio C Hamano, Jan 12, 2010
  18. 14/18 sha1_file.c: remove unused functionJunio C Hamano, Jan 12, 2010
  19. 15/18 strbuf.c: remove unused functionJunio C Hamano, Jan 12, 2010
  20. 16/18 blob.c: remove unused functionJunio C Hamano, Jan 12, 2010
  21. Daniel BarkalowJan 12, 2010
  22. Junio C HamanoJan 13, 2010
  23. 17/18 object.c: remove unused functionsJunio C Hamano, Jan 12, 2010
  24. 18/18 symlinks.c: remove unused functionsJunio C Hamano, Jan 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.