git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 05/18] http.c: mark file-local functions static

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 12, 2010, 07:52 UTC
Message-ID
<1263282781-25596-6-git-send-email-gitster@pobox.com>
In-Reply-To
<1263282781-25596-1-git-send-email-gitster@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 http.c |   10 ++++++++--
 http.h |    9 ---------
 2 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/http.c b/http.c
index 5c3efb9..deab595 100644
--- a/http.c
+++ b/http.c
@@ -651,7 +651,7 @@ static void closedown_active_slot(struct active_request_slot *slot)
 	slot->in_use = 0;
 }
 
-void release_active_slot(struct active_request_slot *slot)
+static void release_active_slot(struct active_request_slot *slot)
 {
 	closedown_active_slot(slot);
 	if (slot->curl && curl_session_count > min_curl_sessions) {
@@ -834,7 +834,13 @@ int http_get_strbuf(const char *url, struct strbuf *result, int options)
 	return http_request(url, result, HTTP_REQUEST_STRBUF, options);
 }
 
-int http_get_file(const char *url, const char *filename, int options)
+/*
+ * Downloads an url and stores the result in the given file.
+ *
+ * If a previous interrupted download is detected (i.e. a previous temporary
+ * file is still around) the download is resumed.
+ */
+static int http_get_file(const char *url, const char *filename, int options)
 {
 	int ret;
 	struct strbuf tmpfile = STRBUF_INIT;
diff --git a/http.h b/http.h
index f828e1d..5c9441c 100644
--- a/http.h
+++ b/http.h
@@ -81,7 +81,6 @@ extern int start_active_slot(struct active_request_slot *slot);
 extern void run_active_slot(struct active_request_slot *slot);
 extern void finish_active_slot(struct active_request_slot *slot);
 extern void finish_all_active_slots(void);
-extern void release_active_slot(struct active_request_slot *slot);
 
 #ifdef USE_CURL_MULTI
 extern void fill_active_slots(void);
@@ -136,14 +135,6 @@ extern char *get_remote_object_url(const char *url, const char *hex,
 int http_get_strbuf(const char *url, struct strbuf *result, int options);
 
 /*
- * Downloads an url and stores the result in the given file.
- *
- * If a previous interrupted download is detected (i.e. a previous temporary
- * file is still around) the download is resumed.
- */
-int http_get_file(const char *url, const char *filename, int options);
-
-/*
  * Prints an error message using error() containing url and curl_errorstr,
  * and returns ret.
  */
-- 
1.6.6.280.ge295b7.dirty
Previous: Johannes SixtNext: Junio C Hamano
Message 9 of 24 in “mark file-local symbols static”
  1. 00/18 mark file-local symbols staticJunio C Hamano, Jan 12, 2010
  2. 01/18 bisect.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  3. 02/18 builtin-rev-list.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  4. 03/18 pretty.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  5. 04/18 date.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  6. Johannes SixtJan 12, 2010
  7. Junio C HamanoJan 12, 2010
  8. Johannes SixtJan 12, 2010
  9. 05/18 http.c: mark file-local functions staticJunio C Hamano, Jan 12, 2010
  10. 06/18 entry.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  11. 07/18 parse-options.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  12. 08/18 read-cache.c: mark file-local functions staticJunio C Hamano, Jan 12, 2010
  13. 09/18 remote-curl.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  14. 10/18 quote.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  15. 11/18 submodule.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  16. 12/18 utf8.c: mark file-local function staticJunio C Hamano, Jan 12, 2010
  17. 13/18 mailmap.c: remove unused functionJunio C Hamano, Jan 12, 2010
  18. 14/18 sha1_file.c: remove unused functionJunio C Hamano, Jan 12, 2010
  19. 15/18 strbuf.c: remove unused functionJunio C Hamano, Jan 12, 2010
  20. 16/18 blob.c: remove unused functionJunio C Hamano, Jan 12, 2010
  21. Daniel BarkalowJan 12, 2010
  22. Junio C HamanoJan 13, 2010
  23. 17/18 object.c: remove unused functionsJunio C Hamano, Jan 12, 2010
  24. 18/18 symlinks.c: remove unused functionsJunio C Hamano, Jan 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.