Re: [PATCH] mingw: disable Python

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Jan 8, 2010, 13:52 UTC
Message-ID: <4B4738AF.9020101@viscovery.net>
In-Reply-To: <7vpr5kpvmh.fsf@alter.siamese.dyndns.org>

Junio C Hamano schrieb:

Show 13 quoted lines

> Erik Faye-Lund <kusmabite@googlemail.com> writes:
>>> On Fri, 8 Jan 2010, Johannes Sixt wrote:
>>>> (how do you undefine a Makefile variable?);
>>> How about
>>>
>>>        NO_PYTHON=
>>>
>>> in config.mak?
>> That doesn't work for me, at least not out of the box. NO_PYTHON is
>> still defined, it's just defined to an empty string.
> 
> I think Dscho is right.  "ifdef FOO" yields (and should yield) false if
> FOO is set to empty.

Indeed. Strange. It didn't work when I tested it a few hours ago, but no it works as you say. According to the docs, 'ifdef' actually does not test defined-ness, but emptyness. So, Erik's original version is fine:

Acked-by: Johannes Sixt <j6t@kdbg.org>

-- Hannes