Re: [PATCH] mingw: disable Python
- From
Erik Faye-Lund <kusmabite@googlemail.com>
- Date
- Jan 8, 2010, 10:49 UTC
- Message-ID
- <40aa078e1001080249t16b0ee01i5ceb8e7ad2426e70@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.1.00.1001081135180.4272@intel-tinevez-2-302>
On Fri, Jan 8, 2010 at 9:07 AM, Johannes Sixt <j.sixt@viscovery.net> wrote:
> Wouldn't it be superior to set > > PYTHON_PATH =
Yes, I think it would. I've tested it (I've got Python 2.6 installed in c:\Python26\, so with your fix I can re-enable it by setting "PYTHON_PATH=/c/Python26/python.exe" in config.mak.
On Fri, Jan 8, 2010 at 11:35 AM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 15 quoted lines
> Hi, > > On Fri, 8 Jan 2010, Johannes Sixt wrote: > >> Erik Faye-Lund schrieb: >> > Python is not commonly installed on Windows machines, so >> > we should disable it there by default. >> > >> > --- a/Makefile >> > +++ b/Makefile >> > @@ -1027,6 +1027,7 @@ ifneq (,$(findstring MINGW,$(uname_S))) >> > + NO_PYTHON = YesPlease >> >> I'm worried that with this solution it is impossible to re-enable Python >> in config.mak (how do you undefine a Makefile variable?);
Show 6 quoted lines
> How about > > NO_PYTHON= > > in config.mak? >
That doesn't work for me, at least not out of the box. NO_PYTHON is still defined, it's just defined to an empty string. I guess we could change to Makefile to accept empty NO_PYTHON as enabled, but since Hannes' suggestion works fine, I think I'll stick with it, even if it's a little inconsistent with the other stuff in the MinGW-section of Makefile.
I'll resend a bit later.
-- Erik "kusma" Faye-Lund