git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [updated patch v3 2/2] Improve transport helper exec failure reporting

From
Johannes Sixt <j6t@kdbg.org>
Date
Dec 31, 2009, 19:05 UTC
Message-ID
<4B3CF60A.4050100@kdbg.org>
In-Reply-To
<1262284003-1417-3-git-send-email-ilari.liusvaara@elisanet.fi>
Ilari Liusvaara schrieb:
Show 7 quoted lines
> +	helper->silent_exec_failure = 1;
> +	if (start_command(helper)) {
> +		if (errno == ENOENT)
> +			die("Unable to find remote helper for \"%s\"",
> +				data->name);
> +		else
> +			die_errno("Unable to run helper %s", helper->argv[0]);

When you fix your implementation of start_command() to follow Documentation/technical/api-run-command.txt, the error message in the else branch is not needed anymore (and then you can ask yourself whether you really want to issue your own error message in the case of ENOENT).

-- Hannes
Previous: Ilari Liusvaara
Message 6 of 6 in “Imporve remote helpers exec failure reporting”
  1. 0/2 Imporve remote helpers exec failure reportingIlari Liusvaara, Dec 31, 2009
  2. 1/2 Report exec errors from run-commandIlari Liusvaara, Dec 31, 2009
  3. Johannes SixtDec 31, 2009
  4. Junio C HamanoJan 5, 2010
  5. 2/2 Improve transport helper exec failure reportingIlari Liusvaara, Dec 31, 2009
  6. Johannes SixtDec 31, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.