From: Johannes Sixt <j6t@kdbg.org>
Date: Thu, 31 Dec 2009 19:05:46 GMT
Subject: Re: [updated patch v3 2/2] Improve transport helper exec failure reporting
Message-ID: <4B3CF60A.4050100@kdbg.org>
In-Reply-To: <1262284003-1417-3-git-send-email-ilari.liusvaara@elisanet.fi>

Ilari Liusvaara schrieb:
> +	helper->silent_exec_failure = 1;
> +	if (start_command(helper)) {
> +		if (errno == ENOENT)
> +			die("Unable to find remote helper for \"%s\"",
> +				data->name);
> +		else
> +			die_errno("Unable to run helper %s", helper->argv[0]);

When you fix your implementation of start_command() to follow 
Documentation/technical/api-run-command.txt, the error message in the else 
branch is not needed anymore (and then you can ask yourself whether you 
really want to issue your own error message in the case of ENOENT).

-- Hannes