Re: [PATCH 2/2] t7508-status: test all modes with color

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Dec 8, 2009, 16:06 UTC
Message-ID: <4B1E798C.5050204@drmicha.warpmail.net>
In-Reply-To: <hflc82$sf8$1@ger.gmane.org>

Jakub Narebski venit, vidit, dixit 08.12.2009 12:10:

Show 14 quoted lines

> Michael J Gruber wrote:
> 
>> +decrypt_color () {
>> +       sed \
>> +               -e 's/.\[1m/<WHITE>/g' \
>> +               -e 's/.\[31m/<RED>/g' \
>> +               -e 's/.\[32m/<GREEN>/g' \
>> +               -e 's/.\[34m/<BLUE>/g' \
>> +               -e 's/.\[m/<RESET>/g'
>> +}
> 
> Shouldn't this be better in test-lib.sh, or some common lib 
> (lib-color.sh or color-lib.sh; we are unfortunately a bit inconsistent
> in naming here)?

Well, so far it's used in two places (and somewhat differently). I would say test-libification starts at 3 :)

Michael