From: Michael J Gruber Date: Tue, 08 Dec 2009 16:06:36 GMT Subject: Re: [PATCH 2/2] t7508-status: test all modes with color Message-ID: <4B1E798C.5050204@drmicha.warpmail.net> In-Reply-To: Jakub Narebski venit, vidit, dixit 08.12.2009 12:10: > Michael J Gruber wrote: > >> +decrypt_color () { >> + sed \ >> + -e 's/.\[1m//g' \ >> + -e 's/.\[31m//g' \ >> + -e 's/.\[32m//g' \ >> + -e 's/.\[34m//g' \ >> + -e 's/.\[m//g' >> +} > > Shouldn't this be better in test-lib.sh, or some common lib > (lib-color.sh or color-lib.sh; we are unfortunately a bit inconsistent > in naming here)? Well, so far it's used in two places (and somewhat differently). I would say test-libification starts at 3 :) Michael