Re: [PATCH 1/4] MSVC: Fix an "unresolved symbol" linker error on cygwin
Show 8 quoted lines
> Johannes Sixt wrote:
>> I understand that you run into this error if you define NO_MMAP in your
>> config.mak. I don't know whether we support NO_MMAP as a knob for to tweak
>> the builds on all platforms. If this is the case (Junio?), then your
>> justification must be updated.
>
> AFAICT, the only build to not support NO_MMAP is MSVC (on cygwin *or* msysGit).
> The solution was obvious and low impact, so why not remove this anomaly?
Sure, why not? But then the justification is different, as I said.
-- Hannes