Re: [PATCH 1/4] MSVC: Fix an "unresolved symbol" linker error on cygwin

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Nov 4, 2009, 19:19 UTC
Message-ID: <4AF1D3A7.2070407@ramsay1.demon.co.uk>
In-Reply-To: <4AEFD9E2.6060004@viscovery.net>

Johannes Sixt wrote:

Show 8 quoted lines

> Ramsay Jones schrieb:
>> When the NO_MMAP build variable is set, which is the case by
>> default on cygwin, the msvc linker complains:
>>
>>     error LNK2001: unresolved external symbol _getpagesize
> 
> Make up your mind: use the cygwin configuration or use the MSVC
> configuration. MSVC doesn't define NO_MMAP for a reason. Where is the problem?

Heh, well as I said elsewhere in this email, the "real problem" is that the MSVC and cygwin configuration sections are not mutually exclusive and that is fixed in patch #3. So, if you apply patch #3, this "problem" disappears.

However, ...

> I understand that you run into this error if you define NO_MMAP in your
> config.mak. I don't know whether we support NO_MMAP as a knob for to tweak
> the builds on all platforms. If this is the case (Junio?), then your
> justification must be updated.

AFAICT, the only build to not support NO_MMAP is MSVC (on cygwin *or* msysGit). The solution was obvious and low impact, so why not remove this anomaly?

(It may even prove to be a useful capability ;-)

ATB, Ramsay Jones