git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] ls-files: make option parser keep argv[0]

From
Stephen Boyd <bebarino@gmail.com>
Date
Oct 8, 2009, 20:32 UTC
Message-ID
<4ACE4C72.4050400@gmail.com>
In-Reply-To
<1255011628-31841-1-git-send-email-bwalton@artsci.utoronto.ca>
Ben Walton wrote:
Show 9 quoted lines
> The ls-files built-in was not asking the option parser to maintain
> argv[0].  This led to the possibility of fprintf(stderr, "...", NULL).
> On Solaris, this was causing a segfault.  On glibc systems, printed
> error messages didn't contain proper strings, but rather, "(null)":...
>
> A trigger for this bug was: `git ls-files -i`
>
> Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
>
Patch looks good.

Just a thought, maybe we should change the fprintf(stderr,...) and exit(1) call to a die() and replace the argv[0] with "ls-files" similar to the die() on line 546. Then your diffstat becomes -1 instead of 0.

Previous: Ben WaltonNext: Ben Walton
Message 2 of 4 in “ls-files: make option parser keep argv[0]”
  1. ls-files: make option parser keep argv[0]Ben Walton, Oct 8, 2009
  2. Stephen BoydOct 8, 2009
  3. ls-files: die instead of fprintf/exit in -i errorBen Walton, Oct 9, 2009
  4. Junio C HamanoOct 9, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.