From: Stephen Boyd <bebarino@gmail.com>
Date: Thu, 08 Oct 2009 20:32:50 GMT
Subject: Re: [PATCH] ls-files: make option parser keep argv[0]
Message-ID: <4ACE4C72.4050400@gmail.com>
In-Reply-To: <1255011628-31841-1-git-send-email-bwalton@artsci.utoronto.ca>

Ben Walton wrote:
> The ls-files built-in was not asking the option parser to maintain
> argv[0].  This led to the possibility of fprintf(stderr, "...", NULL).
> On Solaris, this was causing a segfault.  On glibc systems, printed
> error messages didn't contain proper strings, but rather, "(null)":...
>
> A trigger for this bug was: `git ls-files -i`
>
> Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
>

Patch looks good.

Just a thought, maybe we should change the fprintf(stderr,...) and
exit(1) call to a die() and replace the argv[0] with "ls-files" similar
to the die() on line 546. Then your diffstat becomes -1 instead of 0.