Re: [BUG?] git-cvsimport: path to cvspsfile
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Sep 24, 2009, 05:59 UTC
- Message-ID
- <4ABB0ACF.5040508@viscovery.net>
- In-Reply-To
- <20090923191428.GA30104@coredump.intra.peff.net>
Jeff King schrieb:
Show 6 quoted lines
> Bug. The script does a chdir() and then looks at the cvspsfile later. I > think "-A" would have the same problem. Here is a totally untested patch > to address the issue. Johannes, will this is_absolute_path actually work > on Windows? I think The Right Way would be to use > File::Spec::file_name_is_absolute, but I haven't checked whether that is > part of core perl and if so, which version it appeared in.
We have File::Spec::file_name_is_absolute in the msysgit installation. I suggest you use it. It sounds like a very basic feature, and I'd be surprised if it were not part of core perl.
-- Hannes