Re: [BUG?] git-cvsimport: path to cvspsfile

From: Jeff King <peff@peff.net>
Date: Sep 24, 2009, 06:11 UTC
Message-ID: <20090924061114.GB24694@coredump.intra.peff.net>
In-Reply-To: <4ABB0ACF.5040508@viscovery.net>

On Thu, Sep 24, 2009 at 07:59:43AM +0200, Johannes Sixt wrote:

Show 11 quoted lines

> Jeff King schrieb:
> > Bug. The script does a chdir() and then looks at the cvspsfile later. I
> > think "-A" would have the same problem. Here is a totally untested patch
> > to address the issue. Johannes, will this is_absolute_path actually work
> > on Windows? I think The Right Way would be to use
> > File::Spec::file_name_is_absolute, but I haven't checked whether that is
> > part of core perl and if so, which version it appeared in.
> 
> We have File::Spec::file_name_is_absolute in the msysgit installation. I
> suggest you use it. It sounds like a very basic feature, and I'd be
> surprised if it were not part of core perl.

Looks like File::Spec at least goes back to perl 5.004, and we are already using it. I'll assume file_name_is_absolute has been there a while, then. Thanks.

-Peff