[PATCH] Round-down years in "years+months" relative date view
- From
- David Reiss <dreiss@facebook.com>
- Date
- Aug 27, 2009, 23:39 UTC
- Message-ID
- <4A97193A.8090502@facebook.com>
Previously, a commit from 1 year and 7 months ago would display as "2 years, 7 months ago".
Signed-off-by: David Reiss <dreiss@facebook.com> ---
Here's my test script. Let me know if you'd rather have it as part of the test suite.
#!/bin/sh set -e REPO="git-relative-dates-test" rm -rf "$REPO" mkdir "$REPO" cd "$REPO" git init NOW=`date +%s` env GIT_AUTHOR_DATE=`expr $NOW - \( 365 + 220 \) \* 24 \* 60 \* 60` git commit --allow-empty -m old-commit git log --date=relative
date.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/date.c b/date.c index 1de1845..e848d96 100644 --- a/date.c +++ b/date.c @@ -137,7 +137,7 @@ const char *show_date(unsigned long time, int tz, enum date_mode mode) } /* Give years and months for 5 years or so */ if (diff < 1825) { - unsigned long years = (diff + 183) / 365; + unsigned long years = diff / 365; unsigned long months = (diff % 365 + 15) / 30; int n; n = snprintf(timebuf, sizeof(timebuf), "%lu year%s",
-- 1.6.0.4