Re: [PATCH] Re: git-am: less strong format "mbox" detection

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Jul 14, 2009, 08:35 UTC
Message-ID: <4A5C436E.8000304@viscovery.net>
In-Reply-To: <20090714082059.GA13808@vidovic>

Nicolas Sebrecht schrieb:

Show 14 quoted lines

> Le 14/07/09, Giuseppe Bilotta a écrit :
> 
>>> diff --git a/git-am.sh b/git-am.sh
>>> index d64d997..d10a8e0 100755
>>> --- a/git-am.sh
>>> +++ b/git-am.sh
>>> @@ -169,7 +169,7 @@ check_patch_format () {
>>>                read l2
>>>                read l3
>>>                case "$l1" in
>>> -               "From "* | "From: "*)
>>> +               "From "* | "From: "* | "X-Account-Key:"* | "Return-Path:"* | "Delivered-To:"*)
> 
> And why should we accept "From "?

Because mbox format must begin with "From ".

The question is rather: Why should we accept anything else? The case arm in question is about detecting mbox format.

-- Hannes