[PATCH] Re: git-am: less strong format "mbox" detection

From: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
Date: Jul 14, 2009, 08:20 UTC
Message-ID: <20090714082059.GA13808@vidovic>
In-Reply-To: <cb7bb73a0907140016r4807c008h9c98f76200e9c3a5@mail.gmail.com>

Le 14/07/09, Giuseppe Bilotta a écrit :

Show 15 quoted lines

> > diff --git a/git-am.sh b/git-am.sh
> > index d64d997..d10a8e0 100755
> > --- a/git-am.sh
> > +++ b/git-am.sh
> > @@ -169,7 +169,7 @@ check_patch_format () {
> >                read l2
> >                read l3
> >                case "$l1" in
> > -               "From "* | "From: "*)
> > +               "From "* | "From: "* | "X-Account-Key:"* | "Return-Path:"* | "Delivered-To:"*)
> 
> Nitpick: for consistency, should we either expect a space after the
> colon also in the new keys, or not expect i in the From: key either. I
> don't think the RFC requires a space, but most clients probably add
> it.

RFC 822 says:
     
" 3.4.2. WHITE SPACE
     
  Note:  In structured field bodies, multiple linear space ASCII
         characters  (namely  HTABs  and  SPACEs) are treated as
         single spaces and may freely surround any  symbol.   In
         all header fields, the only place in which at least one
         LWSP-char is REQUIRED is at the beginning of  continua-
         tion lines in a folded field.
"

A trailing space after the colon is not required. I'll remove it and resend a patch.

And why should we accept "From "?

-- 
Nicolas Sebrecht