Re: [PATCHv2 1/3] git-sh-setup: introduce say() for quiet options

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Jun 15, 2009, 06:25 UTC
Message-ID: <4A35E970.8080406@viscovery.net>
In-Reply-To: <1245021374-8430-2-git-send-email-bebarino@gmail.com>

Stephen Boyd schrieb:

Show 14 quoted lines

> diff --git a/git-sh-setup.sh b/git-sh-setup.sh
> index 80acb7d..f88184e 100755
> --- a/git-sh-setup.sh
> +++ b/git-sh-setup.sh
> @@ -44,6 +44,13 @@ die() {
>  	exit 1
>  }
>  
> +say () {
> +	if test -z "$GIT_QUIET"
> +	then
> +		echo "$@"
> +	fi
> +}

Is it intended that this obeys any GIT_QUIET that appears in the environment? If not, then you should add

GIT_QUIET=

here to override the environment.

-- Hannes