git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH 8/6] Fix zero context insert and delete hunk headers to match CGit

From
Ferry Huberts (Pelagic) <ferry.huberts@pelagic.nl>
Date
May 3, 2009, 08:31 UTC
Message-ID
<49FD5662.9070004@pelagic.nl>
In-Reply-To
<200905031025.53084.robin.rosenberg.lists@dewire.com>
Show 6 quoted lines
> 3) We should have a convention like C Git for marking known breakages.
> One option is FIXME, another it so go JUnit 4 and abuse the expected exception 
> annotation (using it for declaring OK exceptions is pretty bad use anyway I think,
> so we might use it for something better), or perhaps the @Ignore annotation which
> is meant specifically for this and other cases. A FIXME can be implemented right
> away.

standard pratice for junit would be to write a test case on what you would expect to be _correct_ behaviour. obviously that test would then fail. it would be a know failure in the test suite. do not go ignoring it. it's better to keep being reminded that stuff doesn't work :-)

Previous: Robin RosenbergNext: Robin Rosenberg
Message 5 of 8 in “BROKEN: Add a zero line context test for diff.DiffFormatter”
  1. 7/6 BROKEN: Add a zero line context test for diff.DiffFormatterShawn O. Pearce, May 3, 2009
  2. 8/6 Fix zero context insert and delete hunk headers to match CGitShawn O. Pearce, May 3, 2009
  3. Miles BaderMay 3, 2009
  4. Robin RosenbergMay 3, 2009
  5. Ferry Huberts (Pelagic)May 3, 2009
  6. Robin RosenbergMay 3, 2009
  7. Ferry Huberts (Pelagic)May 3, 2009
  8. SZEDER GáborMay 5, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.