git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH 8/6] Fix zero context insert and delete hunk headers to match CGit

From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date
May 3, 2009, 08:25 UTC
Message-ID
<200905031025.53084.robin.rosenberg.lists@dewire.com>
In-Reply-To
<8763gjdn6r.fsf@catnip.gol.com>
söndag 03 maj 2009 02:50:36 skrev Miles Bader <miles@gnu.org>:
Show 7 quoted lines
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> >   And here is that hack.  It just feels wrong to me that I need
> >   to subtract 1 from the Edit region's line numbers, *only* when
> >   context is 0, in order to get the same output as CGit.
> 
> A big comment saying "this may look a bit funny, but it's the standard's
> fault: [text from std...]" might help salve the wound...
1) I agree. This need to be commented in the code.
2) Do we need to fix it? I.e. is there a problem or just two different results,
where one is correct, the other incorrect but harmless.
3) We should have a convention like C Git for marking known breakages.
One option is FIXME, another it so go JUnit 4 and abuse the expected exception 
annotation (using it for declaring OK exceptions is pretty bad use anyway I think,
so we might use it for something better), or perhaps the @Ignore annotation which
is meant specifically for this and other cases. A FIXME can be implemented right
away.
-- robin
Previous: Miles BaderNext: Ferry Huberts (Pelagic)
Message 4 of 8 in “BROKEN: Add a zero line context test for diff.DiffFormatter”
  1. 7/6 BROKEN: Add a zero line context test for diff.DiffFormatterShawn O. Pearce, May 3, 2009
  2. 8/6 Fix zero context insert and delete hunk headers to match CGitShawn O. Pearce, May 3, 2009
  3. Miles BaderMay 3, 2009
  4. Robin RosenbergMay 3, 2009
  5. Ferry Huberts (Pelagic)May 3, 2009
  6. Robin RosenbergMay 3, 2009
  7. Ferry Huberts (Pelagic)May 3, 2009
  8. SZEDER GáborMay 5, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.