Re: [PATCHv2 4/4] Rename push.default to push.mode

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Mar 31, 2009, 12:55 UTC
Message-ID: <49D212B0.8070005@drmicha.warpmail.net>
In-Reply-To: <20090330180253.GA7220@coredump.intra.peff.net>

Jeff King venit, vidit, dixit 30.03.2009 20:02:

Show 20 quoted lines

> On Mon, Mar 30, 2009 at 04:47:20PM +0200, Michael J Gruber wrote:
> 
>> Thanks for the explanation! I rechecked, and for sure it also happened
>> with patches from Tor Arne Vestbø and Nguyễn Thái Ngọc Duy.
>> Again I feel blessed by my umlautlessness... and challenged by gmane.
>> About time to ditch it for reading patches also, or at least to be aware
>> of it when saving patches.
> 
> The message gmane passes out has the content-transfer-encoding set
> properly. Your newsreader should properly un-QP it, or if it has an
> option to save it directly (encoding and all), then "git am" will un-QP
> it. If you were to "git apply" it directly, that would break, though
> (and it is user error). If your newsreader saves the QP text without the
> matching header, then that would also break (and your newsreader is
> broken).
> 
> Just curious how you are seeing the breakage (because I want to make
> sure there is no git bug).
> 
> -Peff

I haven't seen any breakage. I just noticed a different font being used for Santi's posts (due to different character encoding, with a different font preset in TB) and looked at the message source, where I saw =20 and such all over the place (message display is fine). When saving from TB the QP is undone. It just made me feel uneasy because of our recent discussion regarding format-flowed and patch submission. I know ff \ne qp, but still I thought git-{send-email,apply} would prefer straight ascii.

Michael