git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] grep: color search patterns

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Mar 10, 2009, 16:38 UTC
Message-ID
<49B6979B.8080900@lsrfire.ath.cx>
In-Reply-To
<fcaeb9bf0903092301i7bc6322dtbd37f662fe4b224b@mail.gmail.com>
Nguyen Thai Ngoc Duy schrieb:
Show 10 quoted lines
> On 3/7/09, René Scharfe <rene.scharfe@lsrfire.ath.cx> wrote:
>> Match coloring is a major missing feature of git grep.  It makes reading
>>  the output much easier and brings grep onto the same visual level as the
>>  other colorized git commands.
> 
> "git --color test" did not colorize the result for me. "git --color
> --no-ext-grep test" did. Maybe you should ignore external grep unless
> it is explicitly requested, like in the last patch. I have very
> limited net access these days. Let's see if I can work out something
> for tomorrow, unless you beat me to it.

I assume with "last patch" you mean your last patch, right? It automatically switched to internal grep if coloring was turned on.

Patch 5 of my series adds support for coloring external greps, but you have to explicitly specify the config option grep.color.external. It can be set by distributors in the system config file -- they should know which grep option is needed.

But I can see that a half-colored git grep can be confusing.
René
Previous: Nguyen Thai Ngoc DuyNext: pclouds@gmail.com
Message 8 of 10 in “grep: color search patterns”
  1. 0/5 grep: color search patternsRené Scharfe, Mar 7, 2009
  2. 1/5 grep: micro-optimize hit collection for AND nodesRené Scharfe, Mar 7, 2009
  3. 2/5 grep: remove grep_opt argument from match_expr_eval()René Scharfe, Mar 7, 2009
  4. 3/5 grep: add pmatch and eflags arguments to match_one_pattern()René Scharfe, Mar 7, 2009
  5. 4/5 grep: color patterns in outputRené Scharfe, Mar 7, 2009
  6. 5/5 grep: add support for coloring with external grepsRené Scharfe, Mar 7, 2009
  7. Nguyen Thai Ngoc DuyMar 10, 2009
  8. René ScharfeMar 10, 2009
  9. grep: prefer builtin over external one when coloring resultspclouds@gmail.com, Mar 16, 2009
  10. René ScharfeMar 16, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.