[PATCH] grep: prefer builtin over external one when coloring results
- From
pclouds@gmail.com <pclouds@gmail.com>
- Date
- Mar 16, 2009, 02:20 UTC
- Message-ID
- <1237170004-27768-1-git-send-email-pclouds@gmail.com>
- In-Reply-To
- <49B6979B.8080900@lsrfire.ath.cx>
As far as I know, not all grep programs support coloring, so we should rely on builtin grep. If you want external grep, set color.grep.external to empty string.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> --- How about this?
builtin-grep.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/builtin-grep.c b/builtin-grep.c index 9e7e766..89489dd 100644 --- a/builtin-grep.c +++ b/builtin-grep.c @@ -825,6 +825,8 @@ int cmd_grep(int argc, const char **argv, const char *prefix) } } + if (opt.color && !opt.color_external) + builtin_grep = 1; if (!opt.pattern_list) die("no pattern given."); if ((opt.regflags != REG_NEWLINE) && opt.fixed)
-- 1.6.1.446.gc7851