git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add bare repository indicator for __git_ps1

From
Marius Storm-Olsen <marius@trolltech.com>
Date
Feb 20, 2009, 22:00 UTC
Message-ID
<499F27F9.8090506@trolltech.com>
In-Reply-To
<499EE324.4050305@tedpavlic.com>
Ted Pavlic said the following on 20.02.2009 18:06:
Show 7 quoted lines
>> +		if test "$(git config --bool core.bare)" == "true"; then
> 
> As discussed in another thread, to be consistent with local coding
>  convention, "test" should be replaced with "[ ... ]".
> 
> Additionally, double equality (==) should be replaced with single 
> equality (=).

Ok, I think I was based off of master at the time. I'll take a closer look. Thanks!

-- .marius

Previous: Ted Pavlic
Message 9 of 9 in “Add bare repository indicator for __git_ps1”
  1. Add bare repository indicator for __git_ps1Marius Storm-Olsen, Feb 20, 2009
  2. Johannes SchindelinFeb 20, 2009
  3. Thomas RastFeb 20, 2009
  4. Michael J GruberFeb 20, 2009
  5. Marius Storm-OlsenFeb 20, 2009
  6. Michael J GruberFeb 20, 2009
  7. Marius Storm-OlsenFeb 20, 2009
  8. Ted PavlicFeb 20, 2009
  9. Marius Storm-OlsenFeb 20, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.