From: Marius Storm-Olsen Date: Fri, 20 Feb 2009 22:00:25 GMT Subject: Re: [PATCH] Add bare repository indicator for __git_ps1 Message-ID: <499F27F9.8090506@trolltech.com> In-Reply-To: <499EE324.4050305@tedpavlic.com> Ted Pavlic said the following on 20.02.2009 18:06: >> + if test "$(git config --bool core.bare)" == "true"; then > > As discussed in another thread, to be consistent with local coding > convention, "test" should be replaced with "[ ... ]". > > Additionally, double equality (==) should be replaced with single > equality (=). Ok, I think I was based off of master at the time. I'll take a closer look. Thanks! -- .marius