git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFH] How to review patches: Documentation/ReviewingPatches?

From
Marius Storm-Olsen <marius@trolltech.com>
Date
Feb 13, 2009, 07:54 UTC
Message-ID
<49952728.2080404@trolltech.com>
In-Reply-To
<alpine.DEB.1.00.0902130055370.26370@racer>
Johannes Schindelin said the following on 13.02.2009 01:08:
Show 6 quoted lines
> There is another reason why I do not want any ReviewingPatches:
> reviewing is already such a tedious process; let's not make it
> harder by forcing a potential reviewer to sift through a document
> (the same could be said about SubmittingPatches; IMHO it just
> repeats what common sense would do anyway when imitating existing
> code).

One thing I've wondered about though when sending patches, is how to send the fixups. Lets say I have a patch serie with 8 patches, do I send the whole serie each time, or do I just send an update to each individual patch? Do I attach it to the previous thread, or start a new one?

I couldn't really draw any conclusion by watching the list, since all methods are used. However, I'd like to do what's easiest for the reviewers and maintainers. Probably a new series each time is easiest for Junio to parse and apply, without single updates deep in a thread. However, that might also be considered a tad 'spamming' of the list?

Though, ignoring mail threads is fairly trivial with threading MUAs ;-) (I've used "Mark thread as read" quite a bit lately :-)

Any opinions, preferably from those that review a lot, and apply patches directly from the mailing list? Maybe this could qualify as a section in Documentation/SubmittingPatches?

-- 
.marius [@trolltech.com]
'if you know what you're doing, it's not research'
Previous: Johannes SchindelinNext: Junio C Hamano
Message 3 of 6 in “[RFH] How to review patches: Documentation/ReviewingPatches?”
  1. Jakub NarebskiFeb 12, 2009
  2. Johannes SchindelinFeb 13, 2009
  3. Marius Storm-OlsenFeb 13, 2009
  4. Junio C HamanoFeb 13, 2009
  5. Johannes SchindelinFeb 13, 2009
  6. Jakub NarebskiFeb 15, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.