git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFH] How to review patches: Documentation/ReviewingPatches?

From
Jakub Narebski <jnareb@gmail.com>
Date
Feb 15, 2009, 01:14 UTC
Message-ID
<200902150214.24146.jnareb@gmail.com>
In-Reply-To
<alpine.DEB.1.00.0902130055370.26370@racer>
On Fri, 13 Feb 2009, Johannes Schindelin wrote:
Show 9 quoted lines
> There is another reason why I do not want any ReviewingPatches: reviewing 
> is already such a tedious process; let's not make it harder by forcing a 
> potential reviewer to sift through a document (the same could be said 
> about SubmittingPatches; IMHO it just repeats what common sense would do 
> anyway when imitating existing code).
> 
> I'd rather suggest to patch submitters to make such a good case that all 
> the world is interested in their patch, throwing a lot of eyeballs (AKA 
> review) at it.

Well, I thought of ReviewingPatches less as of listing set of rules to follow, as in the case of SubmittingPatches (because there output is processed by tools, and preserved), but rather as set of guidelines and hints. Something like "rules" of programming :-).

-- 
Jakub Narebski
Poland
Previous: Johannes Schindelin
Message 6 of 6 in “[RFH] How to review patches: Documentation/ReviewingPatches?”
  1. Jakub NarebskiFeb 12, 2009
  2. Johannes SchindelinFeb 13, 2009
  3. Marius Storm-OlsenFeb 13, 2009
  4. Junio C HamanoFeb 13, 2009
  5. Johannes SchindelinFeb 13, 2009
  6. Jakub NarebskiFeb 15, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.