Re: [PATCH] git-filter-branch: Add more error-handling

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Feb 11, 2009, 15:36 UTC
Message-ID: <4992F07F.2080005@viscovery.net>
In-Reply-To: <4992E79D.10208@viscovery.net>

Johannes Sixt schrieb:

Show 8 quoted lines

>> @@ -483,7 +486,7 @@ test -z "$ORIG_GIT_INDEX_FILE" || {
>>  }
>>  
>>  if [ "$(is_bare_repository)" = false ]; then
>> -	git read-tree -u -m HEAD
>> +	git read-tree -u -m HEAD || die "Unable to checkout rewritten tree"
> 
> Here you shouldn't die.

I take this back. I was distracted by the 'exit $ret' that is visible in the context:

>>  fi
>>  
>>  exit $ret

But this exit statement is pointless: ret is initialized to zero and never changed.

-- Hannes