Re: [PATCHv3] filter-branch: Add more error-handling

From: Eric Kidd <git@randomhacks.net>
Date: Feb 11, 2009, 21:00 UTC
Message-ID: <431341160902111300r1a1c3a22n3c098a7d824a3fca@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0902112145400.10279@pacific.mpi-cbg.de>

On Wed, Feb 11, 2009 at 3:48 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> I haven't checked, but is "$tempdir" not the working directory?  If so,
> this would lead to funny interaction with --tree-filter.  Rather, I'd
> write the file into "$GIT_DIR".  Likewise the other files.

The working directory actually lives one level down:

 tempdir=.git-rewrite
 workdir="$tempdir/t"

At the end of the script, git-filter-branch cleans up all of its temporary files by deleting $tempdir. There's actually a fair bit of stuff in there already, and none of it interferes with --tree-filter.

Show 5 quoted lines

> That's not how it is supposed to be used.  Rather,
>
>        test_expect_success $LABEL '
>                test_must_fail git filter-branc $OPTIONS
>        '

Will fix. Thank you.

I really appreciate all this feedback from the git team. Thank you for taking the time to help me get this right!

Cheers, Eric