git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] handle empty notes gracefully

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Feb 6, 2009, 15:49 UTC
Message-ID
<498C5BFA.7030107@viscovery.net>
In-Reply-To
<alpine.DEB.1.00.0902061636320.7377@intel-tinevez-2-302>
Johannes Schindelin schrieb:
Show 6 quoted lines
> On Fri, 6 Feb 2009, Michael J Gruber wrote:
>> +test_expect_success 'handle empty notes gracefully' '
>>  	git notes show || test 1 = $?
> 
> Completely forgot to mention that I think you want to use test_must_fail 
> here.

Wouldn't work. We want to differentiate between different exit codes. But after test_must_fail the exit code is gone. In this simple case this should work:

	git notes show; test 1 = $?
-- Hannes
Previous: Johannes SchindelinNext: Michael J Gruber
Message 5 of 9 in “git notes show: handle empty notes gracefully”
  1. 0/2 git notes show: handle empty notes gracefullyMichael J Gruber, Feb 6, 2009
  2. 1/2 git notes show: test empty notesMichael J Gruber, Feb 6, 2009
  3. 2/2 handle empty notes gracefullyMichael J Gruber, Feb 6, 2009
  4. Johannes SchindelinFeb 6, 2009
  5. Johannes SixtFeb 6, 2009
  6. Michael J GruberFeb 6, 2009
  7. Johannes SchindelinFeb 6, 2009
  8. Michael J GruberFeb 6, 2009
  9. Michael J GruberFeb 6, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.