Re: [PATCH 0/2] git notes show: handle empty notes gracefully

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Feb 6, 2009, 15:37 UTC
Message-ID: <498C5923.8070009@drmicha.warpmail.net>
In-Reply-To: <1233933543-28407-1-git-send-email-git@drmicha.warpmail.net>

Michael J Gruber venit, vidit, dixit 06.02.2009 16:19:

Show 15 quoted lines

> "git notes show" barfs when there is no note to show. This introduces a
> test (yes, a test!) and, in a second round, reacts more gracefully to
> empty notes and adjust the expected test output accordingly.
> 
> Note that in both cases (before/after the patch) the return code is
> non-zero: It's 128 in the ungraceful case, 1 when "dieing gracefully",
> uhm...
> 
> Michael J Gruber (2):
>   git notes show: test empty notes
>   handle empty notes gracefully
> 
>  git-notes.sh     |    2 ++
>  t/t3301-notes.sh |    5 +++++
>  2 files changed, 7 insertions(+), 0 deletions(-)

Uhm, I'm about 1 hour late with my afternoon coffee, and I'm afraid that shows:

1) I meant "bark", not "barf", although both make sense here.

2) When did "format.signoff = true" in config stop working? OK, it never
did. So please consider this (anyway trivial series):

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>