git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/4] Add find_insert_index, insert_at_index and clear_func functions to string_list

From
Marius Storm-Olsen <marius@trolltech.com>
Date
Feb 2, 2009, 07:49 UTC
Message-ID
<4986A5A7.2000900@trolltech.com>
In-Reply-To
<7viqnto7zo.fsf@gitster.siamese.dyndns.org>
Junio C Hamano said the following on 02.02.2009 04:03:
Show 17 quoted lines
> Marius Storm-Olsen <marius@trolltech.com> writes:
> 
>> string_list_find_insert_index() and string_list_insert_at_index()
>> enables you to see if an item is in the string_list, and to
>> insert at the appropriate index in the list, if not there. This
>> is usefull if you need to manipulate an existing item, if
>> present, and insert a new item if not.
>> 
>> Future mailmap code will use this construct to enable complex
>> (old_name, old_email) -> (new_name, new_email) lookups.
>> 
>> The string_list_clear_func() allows to call a custom cleanup
>> function on each item in a string_list, which is useful is the
>> util member points to a complex structure.
> 
> What's with these overlong lines?  You do not have them in your
> other patches.

Sorry, that was my editor which wrapped them visibly at column 70, and I forgot to insert manual line-breaks before saving. I'll correct it for the next version.

-- 
.marius [@trolltech.com]
'if you know what you're doing, it's not research'
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 15 in “Extend mailmap functionality”
  1. 0/4 Extend mailmap functionalityMarius Storm-Olsen, Feb 1, 2009
  2. 1/4 Add log.mailmap as configurational option for mailmap locationMarius Storm-Olsen, Feb 1, 2009
  3. 2/4 Add find_insert_index, insert_at_index and clear_func functions to string_listMarius Storm-Olsen, Feb 1, 2009
  4. 3/4 Add map_user() and clear_mailmap() to mailmapMarius Storm-Olsen, Feb 1, 2009
  5. 4/4 Change current mailmap usage to do matching on both name and email of author/committer.Marius Storm-Olsen, Feb 1, 2009
  6. Junio C HamanoFeb 2, 2009
  7. Marius Storm-OlsenFeb 2, 2009
  8. Junio C HamanoFeb 2, 2009
  9. Marius Storm-OlsenFeb 2, 2009
  10. Junio C HamanoFeb 2, 2009
  11. Marius Storm-OlsenFeb 2, 2009
  12. Junio C HamanoFeb 2, 2009
  13. Junio C HamanoFeb 2, 2009
  14. Sverre RabbelierFeb 2, 2009
  15. Marius Storm-OlsenFeb 2, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.