From: Marius Storm-Olsen <marius@trolltech.com>
Date: Mon, 02 Feb 2009 07:49:59 GMT
Subject: Re: [PATCH v2 2/4] Add find_insert_index, insert_at_index and clear_func functions to string_list
Message-ID: <4986A5A7.2000900@trolltech.com>
In-Reply-To: <7viqnto7zo.fsf@gitster.siamese.dyndns.org>

Junio C Hamano said the following on 02.02.2009 04:03:
> Marius Storm-Olsen <marius@trolltech.com> writes:
> 
>> string_list_find_insert_index() and string_list_insert_at_index()
>> enables you to see if an item is in the string_list, and to
>> insert at the appropriate index in the list, if not there. This
>> is usefull if you need to manipulate an existing item, if
>> present, and insert a new item if not.
>> 
>> Future mailmap code will use this construct to enable complex
>> (old_name, old_email) -> (new_name, new_email) lookups.
>> 
>> The string_list_clear_func() allows to call a custom cleanup
>> function on each item in a string_list, which is useful is the
>> util member points to a complex structure.
> 
> What's with these overlong lines?  You do not have them in your
> other patches.

Sorry, that was my editor which wrapped them visibly at column 70, and 
I forgot to insert manual line-breaks before saving.
I'll correct it for the next version.

-- 
.marius [@trolltech.com]
'if you know what you're doing, it's not research'