Re: [PATCH 1/2] fsck: HEAD is part of refs

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Jan 30, 2009, 09:27 UTC
Message-ID: <4982C7FA.20107@viscovery.net>
In-Reply-To: <7veiylb1in.fsf_-_@gitster.siamese.dyndns.org>

Junio C Hamano schrieb:

Show 5 quoted lines

> By default we looked at all refs but not HEAD.  The only thing that
> made fsck not lose sight of comments that are only reachable from a
> detached HEAD was the reflog for the HEAD.
> 
> This fixes it, with a new test.

[...]

Show 9 quoted lines

> +test_expect_success setup '
> +	test_commit A &&
> +	git checkout HEAD^0 &&
> +	test_commit B &&
> +	git reflog expire --expire=now --all
> +'
> +
> +test_expect_success 'HEAD is part of refs' '
> +	test 0 = $(git fsck | wc -l)

I'm scratching my head over this. This test succeeds even without the change... (Tested with a34a9db.)

-- Hannes