Re: [PATCH] git-svn: fix SVN 1.1.x compatibility

From: Tom G. Christensen <tgc@statsbiblioteket.dk>
Date: Jan 20, 2009, 08:11 UTC
Message-ID: <49758731.4010305@statsbiblioteket.dk>
In-Reply-To: <20090120012301.GA30236@dcvr.yhbt.net>

Eric Wong wrote:

Show 22 quoted lines

> "Tom G. Christensen" <tgc@statsbiblioteket.dk> wrote:
>> Eric Wong wrote:
>>> The get_log() function in the Perl SVN API introduced the limit
>>> parameter in 1.2.0.  However, this got discarded in our SVN::Ra
>>> compatibility layer when used with SVN 1.1.x.  We now emulate
>>> the limit functionality in older SVN versions by preventing the
>>> original callback from being called if the given limit has been
>>> reached.  This emulation is less bandwidth efficient, but SVN
>>> 1.1.x is becoming rarer now.
>>>
>>> Additionally, the --limit parameter in svn(1) uses the
>>> aforementioned get_log() functionality change in SVN 1.2.x.
>>> t9129 no longer depends on --limit to work and instead uses
>>> Perl to parse out the commit message.
>>>
>>> Thanks to Tom G. Christensen for the bug report.
>>>
>>> Signed-off-by: Eric Wong <normalperson@yhbt.net>
>> I applied this to 1.6.1 and the testsuite now passes using SVN 1.1.4 on  
>> RHEL 4/i386 (t9106 still fails on RHEL 4/x86_64).
> 
> Any chance I could have access to that RHEL4/x86_64 environment?

Unfortunately I can't offer that. It is really just a mock buildroot, and it should be possible to recreate the problem with CentOS 4/x86_64. On Fedora Linux the default mock install has a suitable config (epel-4). If you're not a Fedora/CentOS person then I could possibly prepare a VMware image for you.

> I'll
> try to work around bugs in older SVN as best I can, but can't guarantee
> anything.
>

I don't expect more than that.

-tgc