Re: [PATCH] git-svn: fix SVN 1.1.x compatibility

From: Eric Wong <normalperson@yhbt.net>
Date: Jan 20, 2009, 01:23 UTC
Message-ID: <20090120012301.GA30236@dcvr.yhbt.net>
In-Reply-To: <4974450D.4090608@statsbiblioteket.dk>

"Tom G. Christensen" <tgc@statsbiblioteket.dk> wrote:

Show 20 quoted lines

> Eric Wong wrote:
>> The get_log() function in the Perl SVN API introduced the limit
>> parameter in 1.2.0.  However, this got discarded in our SVN::Ra
>> compatibility layer when used with SVN 1.1.x.  We now emulate
>> the limit functionality in older SVN versions by preventing the
>> original callback from being called if the given limit has been
>> reached.  This emulation is less bandwidth efficient, but SVN
>> 1.1.x is becoming rarer now.
>>
>> Additionally, the --limit parameter in svn(1) uses the
>> aforementioned get_log() functionality change in SVN 1.2.x.
>> t9129 no longer depends on --limit to work and instead uses
>> Perl to parse out the commit message.
>>
>> Thanks to Tom G. Christensen for the bug report.
>>
>> Signed-off-by: Eric Wong <normalperson@yhbt.net>
>
> I applied this to 1.6.1 and the testsuite now passes using SVN 1.1.4 on  
> RHEL 4/i386 (t9106 still fails on RHEL 4/x86_64).

Any chance I could have access to that RHEL4/x86_64 environment? I'll try to work around bugs in older SVN as best I can, but can't guarantee anything.

-- 
Eric Wong