git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Use is_pseudo_dir_name everywhere

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Jan 9, 2009, 07:03 UTC
Message-ID
<4966F6BB.90408@viscovery.net>
In-Reply-To
<1231457063-29186-3-git-send-email-aspotashev@gmail.com>
Alexander Potashev schrieb:
> -		if ((ent->d_name[0] == '.') &&
> -		    (ent->d_name[1] == 0 ||
> -		     ((ent->d_name[1] == '.') && (ent->d_name[2] == 0))))
> +		if (is_pseudo_dir_name(ent->d_name))
Nit-pick: When I read the resulting code, then I will have to look up that
  is_pseudo_dir_name() indeed only checks for "." and "..". But if it were
named is_dot_or_dotdot(), then I would have to do that.
-- Hannes
Previous: Alexander PotashevNext: Johannes Sixt
Message 4 of 8 in “Allow cloning to an existing empty directory”
  1. 0/2 Allow cloning to an existing empty directoryAlexander Potashev, Jan 8, 2009
  2. 1/2 Allow cloning to an existing empty directoryAlexander Potashev, Jan 8, 2009
  3. 2/2 Use is_pseudo_dir_name everywhereAlexander Potashev, Jan 8, 2009
  4. Johannes SixtJan 9, 2009
  5. Johannes SixtJan 9, 2009
  6. Junio C HamanoJan 9, 2009
  7. Alexander PotashevJan 9, 2009
  8. Junio C HamanoJan 10, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.