From: Johannes Sixt Date: Fri, 09 Jan 2009 07:03:23 GMT Subject: Re: [PATCH 2/2] Use is_pseudo_dir_name everywhere Message-ID: <4966F6BB.90408@viscovery.net> In-Reply-To: <1231457063-29186-3-git-send-email-aspotashev@gmail.com> Alexander Potashev schrieb: > - if ((ent->d_name[0] == '.') && > - (ent->d_name[1] == 0 || > - ((ent->d_name[1] == '.') && (ent->d_name[2] == 0)))) > + if (is_pseudo_dir_name(ent->d_name)) Nit-pick: When I read the resulting code, then I will have to look up that is_pseudo_dir_name() indeed only checks for "." and "..". But if it were named is_dot_or_dotdot(), then I would have to do that. -- Hannes