Re: [PATCH 1/2] submodule: preserve all arguments exactly when recursing
- From
Kevin Ballard <kevin@sb.org>
- Date
- Nov 3, 2010, 05:49 UTC
- Message-ID
- <4938B399-3872-4352-9A78-BACAF5ECE38B@sb.org>
- In-Reply-To
- <20101103054751.GE10631@burratino>
On Nov 2, 2010, at 10:47 PM, Jonathan Nieder wrote:
Show 12 quoted lines
> Kevin Ballard wrote: >> On Nov 2, 2010, at 9:37 PM, Jonathan Nieder wrote: > >>> Have you looked into "git rev-parse --sq-quote"? >> >> Well crud, I wish I'd seen that before. Looks like it does pretty much the >> exact same thing as my quote_words function. I'll send out another patch >> that uses this instead of quote_words. Thanks for the info! > > Incidentally, if you still remember where it might have been useful > to find this advertised (git-sh-setup?), maybe we can find a way to document > it better.
It might make sense to mention it in CodingGuidelines. That's where I always look when writing shell code in order to make sure I'm not using any bashisms.
-Kevin Ballard