Re: [PATCHv2 2/2] submodule: only preserve flags across recursive status/update invocations

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Nov 3, 2010, 05:38 UTC
Message-ID: <20101103053827.GD10631@burratino>
In-Reply-To: <1288760740-10075-2-git-send-email-kevin@sb.org>

Kevin Ballard wrote:

> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -374,41 +374,35 @@ cmd_init()

[...]

Show 6 quoted lines

>  		--reference)
>  			case "$2" in '') usage ;; esac
>  			reference="--reference=$2"
> -			shift 2
> +			orig_flags="$orig_flags $(git rev-parse --sq-quote "$1")"
> +			shift

Hmm.  Maybe a helper would make it clearer.

	save_arg () {
		orig_flags="$orig_flags $(git rev-parse --sq-quote "$1")"
	}

making this

 +			save_arg --reference
 +			shift

Show 7 quoted lines

> --- a/t/t7407-submodule-foreach.sh
> +++ b/t/t7407-submodule-foreach.sh
> @@ -238,4 +238,23 @@ test_expect_success 'use "git clone --recursive" to checkout all submodules' '
>  	test -d clone4/nested1/nested2/nested3/submodule/.git
>  '
>  
> +test_expect_success 'use "update --recursive nested1" to checkout all submodules rooted in nested1' '

Maybe a submodule status --cached --recursive -- <files> test, too?

Sleepily, Jonathan