Re: [PATCH v2] correct verify_path for Windows
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Oct 13, 2008, 06:00 UTC
- Message-ID
- <48F2E410.2080504@viscovery.net>
- In-Reply-To
- <20081012181836.GA10626@steel.home>
Alex Riesen schrieb:
> I looked at the callers (briefly). Performance could be a problem: add > and checkout can work with real big file lists and long pathnames. > So ok, than. It is critical.
You are kidding, aren't you? What you win by a few CPU instructions here is dwarfed by the time that the stat() implementation requires. Dmitry, please use the more readable tolower().
-- Hannes