Re: Files with colons under Cygwin

From: Dmitry Potapov <dpotapov@gmail.com>
Date: Oct 5, 2008, 19:51 UTC
Message-ID: <20081005195129.GP21650@dpotapov.dyndns.org>
In-Reply-To: <81b0412b0810050214w15a25e3axfb8bf3ca05ffc215@mail.gmail.com>

On Sun, Oct 05, 2008 at 11:14:00AM +0200, Alex Riesen wrote:

Show 8 quoted lines

> 2008/10/5 Dmitry Potapov <dpotapov@gmail.com>:
> > So, here is a patch. It basically disallow backslashes and colons in
> > file names on Windows (whether it is MinGW or Cygwin).
> 
> With this and sparse checkout patch combined it maybe possible
> to make Git work on these backward filesystems in a saner way:
> just never checkout the names which the filesystems cannot support
> on disk and mark them correspondingly in the index.

Perhaps, using sparse checkout is a good idea for dealing with prohibit characters, but the goal of my patch was a bit different -- to close a security hole in checkout when files outside of the working directory can be overwritten. In fact, the whole point of having verify_path() is to prevent this from happening, and if it does not work properly on Windows then this function should be corrected.

Dmitry